Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): playwright plugin clean up #18447

Merged

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Aug 2, 2023

Current Behavior

  • playwright browsers won't be installed in new workspaces, which causes tests to fail if not already installed
  • Playwright plugin cannot be published with providence
  • plugin needs some clean up

Expected Behavior

  • new --skipInstall option to opt out of install playwright browser before running or when generating projects
  • add public access for publishing
  • clean up ensurePackage for angular + cypress (not needed)
  • remove implicitDeps for angular plugin. graph edges are already drawn, so it's not needed
    jest,workspace,cypress,playwright graph edges being used in angular

TODO:

  • rename runCypress utils to be runE2E and like env vars

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 5:47pm

@barbados-clemens barbados-clemens self-assigned this Aug 2, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Aug 2, 2023
@barbados-clemens barbados-clemens enabled auto-merge (squash) August 2, 2023 18:30
@barbados-clemens barbados-clemens merged commit 5e51cd6 into nrwl:master Aug 2, 2023
15 checks passed
@barbados-clemens barbados-clemens deleted the fix/playwright-follow-up branch August 2, 2023 20:42
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants