Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): do not set default target #18454

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 3, 2023

closed #18148

Current Behavior

Our vite executor sets esnext as default target. That behaviour overrides any target set by the user in vite.config, and does not let vite use its default one.

Expected Behavior

Our vite executor should not force a default value for target.

Related Issue(s)

Fixes #18148

@mandarini mandarini requested a review from a team as a code owner August 3, 2023 08:21
@mandarini mandarini requested a review from jaysoo August 3, 2023 08:21
@mandarini mandarini self-assigned this Aug 3, 2023
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 8:23am

@mandarini mandarini requested review from ndcunningham and removed request for jaysoo August 3, 2023 08:21
@mandarini mandarini merged commit bf5111c into nrwl:master Aug 3, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
@mandarini mandarini deleted the fix/vite-target-unset branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite plugin should not default to ESNext!
2 participants