Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add babel/core when babel/preset-react is preset #18462

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Our app generators add @babel/preset-react which has dependencies with peer deps to @babel/core, but this fails with PnP because the @babel/core ends up being nested.

Expected Behavior

The @babel/core needs to be added to package.json when using babel

Related Issue(s)

Fixes #

@meeroslav meeroslav added the scope: react Issues related to React support for Nx label Aug 3, 2023
@meeroslav meeroslav self-assigned this Aug 3, 2023
@meeroslav meeroslav requested a review from a team as a code owner August 3, 2023 10:31
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 10:35am

@meeroslav meeroslav merged commit b317458 into nrwl:master Aug 3, 2023
16 checks passed
@meeroslav meeroslav deleted the add-babel-core branch August 3, 2023 19:33
Comment on lines +100 to +105
"cli": "nx",
"version": "16.7.0-beta.2",
"description": "Add @babel/core to package.json if @babel/preset-react is present",
"implementation": "./src/migrations/update-16-7-0/add-babel-core"
},
"add-babel-core": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section looks like it is under the wrong migration

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react Issues related to React support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants