-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add babel/core when babel/preset-react is preset #18462
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"cli": "nx", | ||
"version": "16.7.0-beta.2", | ||
"description": "Add @babel/core to package.json if @babel/preset-react is present", | ||
"implementation": "./src/migrations/update-16-7-0/add-babel-core" | ||
}, | ||
"add-babel-core": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section looks like it is under the wrong migration
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Our app generators add
@babel/preset-react
which has dependencies with peer deps to@babel/core
, but this fails withPnP
because the@babel/core
ends up being nested.Expected Behavior
The
@babel/core
needs to be added to package.json when usingbabel
Related Issue(s)
Fixes #