Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): use provideRouter for standalone remote apps #18468

Conversation

jnabrdalik
Copy link
Contributor

Current Behavior

Remote applications based on standalone components generated using
nx g @nx/angular:remote remote-name --standalone
or
nx g @nx/angular:host shell --remotes=remote-name --standalone

use importProvidersFrom in their bootstrap.ts while an already generated and currently unused appConfig with provideRouter from newer Router API could be used.

It is worth noting that generators for other types of applications were already switched to use the new API in #12012. That also includes generating host applications using the command above.

Expected Behavior

Generated remote applications with standalone components utilize already generated appConfig with provideRouter instead of importProvidersFrom in their bootstrap.ts files. This way all generators for standalone components applications use the same newer Router API.

Related Issue(s)

Fixes #

@jnabrdalik jnabrdalik requested a review from a team as a code owner August 3, 2023 16:07
@jnabrdalik jnabrdalik requested a review from Coly010 August 3, 2023 16:07
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 4:13pm

@Coly010 Coly010 merged commit 64492ec into nrwl:master Aug 3, 2023
15 checks passed
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants