Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): fetch plugin stats in CI #18498

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Aug 4, 2023

  • Fetch plugin stats when Vercel deploys the nx-dev site.
  • The nx-dev deploy will not overwrite quality-indicators.json if npm stats or github stars apis are down
  • Adds about 1.5 minutes to the deploy time
  • Consolidates all the network calls to fetch github stars into a single network call. (Couldn't find a graphql endpoint for npm to do the same thing for those network calls)

@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 5:02pm

.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove the quality-indicators.json from repo nor break the deploy if npm/github api are unavailable.

@FrozenPandaz FrozenPandaz merged commit 7de3046 into nrwl:master Aug 8, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants