fix(testing): playwright cleanup #18558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 tasks
barbados-clemens
force-pushed
the
fix/playwright-cleanup
branch
from
8f9fe92
to
0db83d2
Compare
barbados-clemens
force-pushed
the
fix/playwright-cleanup
branch
from
0db83d2
to
465d907
Compare
barbados-clemens
added
the
scope: testing tools
barbados-clemens
force-pushed
the
fix/playwright-cleanup
branch
from
465d907
to
2b76fbf
Compare
barbados-clemens
force-pushed
the
fix/playwright-cleanup
branch
from
2b76fbf
to
fdb8de6
Compare
| "default": "playwright" | ||
| "default": "e2e" |
There was a problem hiding this comment.
switch to e2e as playwright directory name is not special like the cypress dir is for cypress plugin.
and e2e is shorter/simpler IMO (open to changing back)
xiongemi
approved these changes
Aug 14, 2023
barbados-clemens
force-pushed
the
fix/playwright-cleanup
branch
from
cc6a2be
to
3cd8fc5
Compare
FrozenPandaz
approved these changes
Aug 14, 2023
isaacplmann
approved these changes
Aug 14, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #