Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): make the default react playwright test to pass #18559

Merged

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Aug 9, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested review from a team as code owners August 9, 2023 22:12
@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 5:47am

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments.

@xiongemi xiongemi merged commit 107a753 into nrwl:master Aug 11, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
@xiongemi xiongemi deleted the bugfix/fix-playwright-default-react-tests branch April 24, 2024 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright e2e test runner doesn't run any tests
3 participants