feat(nx): cypress supportFile handling #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcabanes
force-pushed
the
feat/cypress/enable-supportfile
branch
4 times, most recently
from
03a7423
to
b9364fb
Compare
|
When supportFile is introduced, it could introduce problems: #1976 |
bcabanes
force-pushed
the
feat/cypress/enable-supportfile
branch
7 times, most recently
from
3ed736e
to
3e3e5e3
Compare
|
@bcabanes is the performance issue addressed? |
bcabanes
force-pushed
the
feat/cypress/enable-supportfile
branch
from
3e3e5e3
to
68dee71
Compare
|
@vsavkin Yes, the performance problem comes from the fact The PR has been rebased. |
This update the Cypress schematic to handle by default the `supportFile` option in `cypress.json` with an example for _custom commands_. Related to nrwl#1609
bcabanes
force-pushed
the
feat/cypress/enable-supportfile
branch
from
68dee71
to
735fc33
Compare
FrozenPandaz
approved these changes
Nov 15, 2019
This was referenced Nov 15, 2019
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update the Cypress schematic to handle by default the
supportFileoption incypress.jsonwith an example for custom commands.Removing the
fork-ts-checker-webpack-pluginpreventing Cypress to successfully load spec files. Furthermore,fork-ts-checker-webpack-pluginis supporting TSLint that has been deprecated.Fixes #1609
Fixes #1976
Fixes #2063