-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): fix path for secondary entrypoints #2498
Conversation
I need some help to add a proper test case |
Hi! Thank you for your PR. I reworked this, so there is now one function responsible for this logic for all builders. You will have to move the logic there: 49168c1#diff-41cb23901d7ec5f38adfd254146e8145R100 Regarding testing: |
Ok, but the genral logic is fine? |
d242dd5
to
78e98e7
Compare
@vsavkin Ready |
91d3a43
to
a8137e5
Compare
unclear why tests failed 🤔 |
@viceice I think the implementation isn't right. Left a comment. |
a8137e5
to
d7898bb
Compare
@vsavkin Ready for another review |
One small comment. Other than that, it looks good. |
Done |
Any hints why tests fail again? |
@viceice will you rebase this PR on |
Ok |
@brandonroberts Done. |
Will you rebase on master again to fix the merge conflicts? Thanks |
@brandonroberts fixed the conficts. Should i rebase and force push? |
@viceice Yes |
0e833fe
to
a9fd0d5
Compare
@brandonroberts done |
Thanks @viceice |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Secondary entrypoint path need to be adjusted to use the prebuild dist.
Current Behavior (This is the behavior we have today, before the PR is merged)
Secondary entrypoints are not adjusted.
Expected Behavior (This is the new behavior we can expect after the PR is merged)
Secondary entrypoints should be adjusted.
Issue
#1765