-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): "cwd" option for commands runner #2501
Conversation
} | ||
}, | ||
"required": ["commands"] | ||
"required": ["commands"], | ||
"additionalProperties": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaysoo - was there any reason we were not restricting additionalProperties
before? Let me know if you can think of any issues with me adding this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want this to be true so we can in theory pass extra params and forward them to the underlying command. We don't do it now, but we should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see - yes, I initially thought we can use the args
option for that - but I can see how it's a different use-case..args
is more powerful / allows interpolation throughout the command and needs to be set-up beforehand in workspace.json
while allowing extra options would be simpler if one would want to just forward them to the underlying command like you say e.g. nx generate-docs frontend --option1="foo" --option2="bar"
I'll remove it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that as a follow-up feature/PR where we do arguments forwarding.
c3d6474
to
c439430
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds a
cwd
option to the@nrwl/workspace:run-commands
builder:(conceptually the same as the
cwd
option when creating a child process in Node)