fix(core): use file path inside git repository in git show command #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsaguet
force-pushed
the
fix-2292
branch
3 times, most recently
from
c3be5d6
to
292ec6f
Compare
jsaguet
changed the title
Use file full path in git show to identify affected files to fix an issue when nx workspace is not at the root of git repository Closes nrwl#2292
jsaguet
changed the title
FrozenPandaz
approved these changes
Feb 28, 2020
vsavkin
pushed a commit
that referenced
this pull request
Mar 10, 2020
Use file full path in git show to identify affected files to fix an issue when nx workspace is not at the root of git repository Closes #2292
|
I guess this also closes #2404, will verify tomorrow |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use file's relative path inside git repository when running
git showto identify affected .json files to fix an issue when nx workspace is not at the root of git repositoryCurrent Behavior (This is the behavior we have today, before the PR is merged)
When NX workspace is not located at the root of git repository and we run affected commands using git repository (with --base option), we end up with the following kind of error message.
It seems this problem occurs for .json files only.
When
defaultReadFileAtRevisionis executed,git showcommand is used with the file name.In the case that NX workspace is not located at the root of git repository, the file path does not match the one inside the git repository which shows the above error.
Expected Behavior (This is the new behavior we can expect after the PR is merged)
The
git showcommand is used with the file's relative path inside git repository folder and therefore the git command properly identifies the file even when NX workspace is not located at the root of git repository. (and error message is not shown anymore)Issue
Closes #2292