Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed DTE tasks in Agents not replayed on the main job #26042

Closed
4 tasks
markwhitfeld opened this issue May 24, 2024 · 6 comments
Closed
4 tasks

Failed DTE tasks in Agents not replayed on the main job #26042

markwhitfeld opened this issue May 24, 2024 · 6 comments
Assignees

Comments

@markwhitfeld
Copy link

Current Behavior

Something very odd started happening today. It seems like failed nx tasks on the agent job are not being replayed on the main job. It was working yesterday.

We are using Distributed Task Execution (NX 18.0.8) with our Playwright (v1.42.1) E2E tests.
I can see that the tests are failing on the Agents and are even being retried on another agent.
Now, if I look at the logs for the main job, the failed tasks are not being replayed, but all the other tasks are. The main job step with the nx run is reporting a non successful completion, but the failed tests are not listed, and their outputs are not available among the outputs of the other successful tasks.

The failures are getting sent to NX cloud, because they can be seen in the run, but the results are missing from the main job.
I can also confirm that no github workflow has changed in the last 2 weeks and that we have not upgraded any packages.

PS. I do notice that we have just crossed the allocated 300k credits of the pro plan. I wasn't sure if that was related, so I created a brand new NX org to test if using that org would fix the issue. It didn't fix the issue.

Expected Behavior

Failed DTE tasks in Agents should be replayed on the main job, making their outputs available to the main job.

GitHub Repo

No response

Steps to Reproduce

  1. n/a

Nx Report

n/a

Failure Logs

No response

Package Manager Version

npm 10.2.4

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@markwhitfeld
Copy link
Author

Possibly related to #21235.
PS. I have sent an email to cloud-support@nrwl.io with the job logs attached.

@markwhitfeld
Copy link
Author

@philipjfulcher I'm not sure if you are the same Philip that responded to my email to support, but this is the related issue I logged on GitHub for tracking and for reference for other users.

@meeroslav
Copy link
Contributor

Hi, @markwhitfeld @KwintenP, can you confirm whether this issue is still happening or has been resolved?

@markwhitfeld
Copy link
Author

@meeroslav It appears that the issue is now resolved.
Will you be adding acceptance tests for this critical part of the NX product workflow?
This was quite a costly bug for us.

@meeroslav meeroslav self-assigned this May 28, 2024
@meeroslav
Copy link
Contributor

Sorry to hear that this bug has affected you significantly. Perhaps @StalkAltan or @rarmatei can chime in on the tests.

Copy link

github-actions bot commented Jul 1, 2024

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants