expo-build-properties doesn't set up Gradle properties and iOS doesn't build the app

[guillempuche]

Current Behavior

I create a blank Expo project with Nx create with this package https://github.com/guillempuche/test-nx-expo/blob/main/apps/expo/package.json (Emily already fixed a problem #26285 (comment)).

When @nx/expo installs expo-build-properties and then runs the Expo app with Expo properties configured https://docs.expo.dev/versions/latest/sdk/build-properties/, Gradle doesn't apply the configuration.

iOS Pod file has the property in ios/Podfile.properties.json, but there's an error building the app on iOS simulator.

Expo build properties are found at apps/expo/app.json https://github.com/guillempuche/test-nx-expo/blob/main/apps/expo/app.json#L46:

      [
        "expo-build-properties",
        {
          "android": {
            "compileSdkVersion": 34,
            "minSdkVersion": 26,
            "targetSdkVersion": 34
          },
          "ios": {
            "deploymentTarget": "13.4"
          }
        }
      ]

Expected Behavior

• Package expo-build-properties is added to package.json
• Android app builds with Gradle properties in android/gradle.properties compileSdkVersion and minSdkVersion
• iOS app builds

GitHub Repo

https://github.com/guillempuche/test-nx-expo/

Steps to Reproduce

1. npm i
2. npm exec nx run expo:install expo-build-properties
3. Android npm exec nx run expo:run-android and iOS `npm exec nx run expo:run-ios
4. Nx doesn't sync expo-build-properties to app's package.json neither build the app successfully.

Nx Report

Node   : 20.14.0
OS     : darwin-arm64
npm    : 10.7.0

nx                 : 19.2.3
@nx/js             : 19.2.3
@nx/jest           : 19.2.3
@nx/linter         : 19.2.3
@nx/eslint         : 19.2.3
@nx/workspace      : 19.2.3
@nx/detox          : 19.2.3
@nx/devkit         : 19.2.3
@nx/eslint-plugin  : 19.2.3
@nx/expo           : 19.2.3
@nx/react          : 19.2.3
@nrwl/tao          : 19.2.3
@nx/web            : 19.2.3
@nx/webpack        : 19.2.3
typescript         : 5.3.3
---------------------------------------
Registered Plugins:
@nx/expo/plugin
@nx/eslint/plugin
@nx/jest/plugin
@nx/detox/plugin

Failure Logs

No response

Package Manager Version

npm 10.7.0

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[xiongemi]

you can run command npx nx install expo --packages=expo-build-properties and it should add expo-build-properties to your project's package.json

I have #26500 to add the project's package.json when doing nx install command. it should be in 19.4.0

[guillempuche]

Good improvement because Expo recommends to use expo install as much as possible.

I run the command but doesn't find the plugin settings at https://github.com/guillempuche/test-nx-expo/blob/main/apps/expo/app.json.

npx nx install expo --packages=expo-build-properties 

> nx run expo:install --packages=expo-build-properties

› Installing 1 SDK 51.0.0 compatible native module using npm
> npm install

up to date, audited 2211 packages in 2s

246 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

No Expo config was found. Please create an Expo config (app.json or app.config.js) in your project root.
Please add the following to your Expo config

{
  "plugins": [
    "expo-build-properties"
  ]
}


——————————————————————————————————————————————————————————————————————————————————————

 NX   Successfully ran target install for project expo (3s)

      With additional flags:
        --packages=expo-build-properties