-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-plugin): add migration schematic #2692
feat(nx-plugin): add migration schematic #2692
Conversation
ce4842f
to
62013d0
Compare
dfbff79
to
3ee9dbc
Compare
Update: small e2e test improvement, and rebased onto latest master. |
9b328b2
to
6b904c7
Compare
6b904c7
to
2f30a0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @devinshoemaker! Everything looks good, but there's one thing to make sure this works well for everyone.
Since migrations.json
is a new asset file, you're going to have to modify the assets
property in the workspace.json to include the migrations file (similar to builders.json
and collection.json
).
Also, we removed docs for web, so you might want to rebase on master and regenerate. (Delete the web doc if it doesn't remove it)
2f30a0d
to
7883d9b
Compare
Do you want the same kind of change to be applied in #2708? |
EDIT |
This change adds a new schematic that generates a migration for an Nx plugin. The user can specify the version for the migration, and optionally add a custom name, description, and whether or not to include package.json updates.
Requested changes made, rebased, and documentation regenerated. |
7883d9b
to
b41c782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This change adds a new schematic that generates a migration for an Nx plugin. The user can specify the version for the migration, and optionally add a custom name, description, and whether or not to include package.json updates.
Examples: