Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-plugin): add "schematic" schematic #2708

Merged
merged 4 commits into from
Apr 16, 2020

Conversation

devinshoemaker
Copy link
Contributor

This change adds a new schematic that generates a schematic for an Nx plugin. The user can specify the name for the schematic and optionally add a custom description.

Examples:

nx g @nrwl/nx-plugin:schematic my-schematic --project=ionic-react
nx g @nrwl/nx-plugin:schematic my-schematic --project=ionic-react --description='My schematic description'

@devinshoemaker devinshoemaker force-pushed the nx-plugin-schematic branch 3 times, most recently from 55e9035 to a312064 Compare March 22, 2020 18:10
@devinshoemaker devinshoemaker marked this pull request as ready for review March 22, 2020 18:11
@devinshoemaker devinshoemaker changed the title Nx plugin schematic feat(nx-plugin): add "schematic" schematic Mar 22, 2020
@Cammisuli Cammisuli self-assigned this Mar 23, 2020
Copy link
Member

@Cammisuli Cammisuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinshoemaker can you add a new e2e test for the "schematic" schematic?

@devinshoemaker
Copy link
Contributor Author

@Cammisuli oops, yeah I can't believe I missed that.

@devinshoemaker
Copy link
Contributor Author

@Cammisuli I added an e2e test, updated the plugin schematic unit tests, and rebased onto master.

Copy link
Member

@Cammisuli Cammisuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinshoemaker
Copy link
Contributor Author

Rebased and regenerated documentation.

@Cammisuli Cammisuli merged commit d385030 into nrwl:master Apr 16, 2020
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants