Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade @typescript-eslint/parser to v8 for @nx/eslint-plugin #27449

Closed
1 of 4 tasks
EelcoLos opened this issue Aug 15, 2024 · 3 comments
Closed
1 of 4 tasks

upgrade @typescript-eslint/parser to v8 for @nx/eslint-plugin #27449

EelcoLos opened this issue Aug 15, 2024 · 3 comments

Comments

@EelcoLos
Copy link

EelcoLos commented Aug 15, 2024

Current Behavior

Currently, trying to upgrade, npm-check-updates will state

@typescript-eslint/parser: @nx/eslint-plugin requires ^6.13.2 || ^7.0.0

while its companion @typescript-eslint/eslint-plugin 7.17.0 → 8.1.0
states that v.8.1.0 is available

Expected Behavior

to be able to update @typescript-eslint/parser to v8 and up as well

GitHub Repo

No response

Steps to Reproduce

  1. try updating packages with peer dependencies

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.16.0
OS             : win32-x64
Native Target  : x86_64-windows
npm            : 10.8.2

nx (global)        : 19.5.7
nx                 : 19.5.7
@nx/js             : 19.5.7
@nx/jest           : 19.5.7
@nx/linter         : 19.5.7
@nx/eslint         : 19.5.7
@nx/workspace      : 19.5.7
@nx/angular        : 19.5.7
@nx/devkit         : 19.5.7
@nx/eslint-plugin  : 19.5.7
@nx/playwright     : 19.5.7
@nx/plugin         : 19.5.7
@nrwl/tao          : 19.5.7
@nx/web            : 19.5.7
@nx/webpack        : 19.5.7
typescript         : 5.5.4
---------------------------------------
Registered Plugins:
@nx/eslint/plugin
@nx-dotnet/core
@nx/jest/plugin
---------------------------------------
Community plugins:
@fortawesome/angular-fontawesome : 0.15.0
@ngrx/component                  : 18.0.2
@ngrx/component-store            : 18.0.2
@ngrx/effects                    : 18.0.2
@ngrx/entity                     : 18.0.2
@ngrx/router-store               : 18.0.2
@ngrx/schematics                 : 18.0.2
@ngrx/store                      : 18.0.2
@ngrx/store-devtools             : 18.0.2
@nx-dotnet/core                  : 2.4.3

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

It also states that this update is needed for potential eslint 9 upgrade

@mtalhafaheem
Copy link

I am also facing the same issue. Please do let me know if you find any solution.

@JamesHenry
Copy link
Collaborator

This should land in Nx 19.7 by the end of the month, you can follow along with #27451 which I have created to avoid the multiple duplicates we currently have open.

The WIP PR is getting very close, so stay tuned. It's not easy because of a large differences in ESLint v9 support across ESLint plugins that Nx sets up for you.

@JamesHenry JamesHenry closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
@EelcoLos
Copy link
Author

thanks for the resolution. the github search of this issue didn't show the similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants