Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nest): extend @nestjs/schematics in @nrwl/nest #2756

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

yharaskrik
Copy link
Contributor

No description provided.

Copy link
Member

@Cammisuli Cammisuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yharaskrik
Copy link
Contributor Author

Sorry it took so long! Just a couple of things have been happening lately.

@onemargaro
Copy link

onemargaro commented Apr 13, 2020

any update of this?, maybe it should be updated to use latest vesion of nest schematics ^7.0.0

@yharaskrik
Copy link
Contributor Author

@onemargaro Waiting on Nrwl to merge it in currently, I can update it to ^7 as long as Nx has updated the nest 7+ as well.

@Cammisuli would you like me to make that change? Or leave it as 6 for now?

@Cammisuli
Copy link
Member

@yharaskrik we'll leave it as 6 for now. Migrating to a major version is outside the scope of this PR.

@Cammisuli Cammisuli merged commit 9916b27 into nrwl:master Apr 16, 2020
@yharaskrik
Copy link
Contributor Author

Sounds great to me

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants