feat(nx-plugin): properly implement and honor --unitTestRunner #2867
Conversation
|
The failed test passed for me locally, so I'm not sure what's up with that one. I also don't believe I modified any files that would affect that package. |
|
@devinshoemaker it's a weird test. Sometimes it fails, sometimes it passes 🤷 |
| @@ -142,4 +142,30 @@ describe('NxPlugin migration', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| describe('--unitTestRunner', () => { | |||
| it('should not generate test files', async () => { | |||
There was a problem hiding this comment.
| it('should not generate test files', async () => { | |
| `describe('none', () => { | |
| it('should not generate test files', async () => { |
| @@ -161,4 +161,40 @@ describe('NxPlugin plugin', () => { | |||
| }) | |||
| ); | |||
| }); | |||
|
|
|||
| describe('--unitTestRunner', () => { | |||
| it('should not generate test files', async () => { | |||
There was a problem hiding this comment.
| it('should not generate test files', async () => { | |
| `describe('none', () => { | |
| it('should not generate test files', async () => { |
| @@ -107,4 +107,27 @@ describe('NxPlugin schematic', () => { | |||
| 'my-schematic custom description' | |||
| ); | |||
| }); | |||
|
|
|||
| describe('--unitTestRunner', () => { | |||
| it('should generate files', async () => { | |||
There was a problem hiding this comment.
| it('should generate files', async () => { | |
| `describe('none', () => { | |
| it('should not generate test files', async () => { |
|
Thanks, @FrozenPandaz! I think that suggestion is a better approach. I'll make that change and push up a new commit, and if @Cammisuli has some input then we can go from there. |
| options.unitTestRunner === 'none' | ||
| ? filter(file => !file.endsWith('.spec.tsx')) | ||
| : noop(), |
There was a problem hiding this comment.
The plugin schematic doesn't have any spec files in the template folder. It's just the index.ts. So this part shouldn't be needed. (If it is needed, it shouldn't have .spec.tsx 😉 )
| options.unitTestRunner === 'none' | |
| ? filter(file => !file.endsWith('.spec.tsx')) | |
| : noop(), |
There was a problem hiding this comment.
😅 fixed and pushed.
devinshoemaker
force-pushed
the
nx-plugin-unit-test-runner
branch
from
e8b1f11
to
9aeafdb
Compare
Co-Authored-By: Jason Jean <jasonjean1993@gmail.com>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior (This is the behavior we have today, before the PR is merged)
@nrwl/nx-pluginhas aunitTestRunnerproperty that is not being honored.Expected Behavior (This is the new behavior we can expect after the PR is merged)
@nrwl/nx-plugindoes not generate unit test configurations or files when--unitTestRunner=noneis passed.