feat(core): add npm dependencies to package.json for publishable libs

[Cammisuli]

Please make sure you have read the submission guidelines before posting an PR

Please make sure that your commit message follows our format.

Example: fix(nx): must begin with lowercase

Current Behavior (This is the behavior we have today, before the PR is merged)

When building libraries, users would have to manually update their library's package.json to include any node_module deps.

Expected Behavior (This is the new behavior we can expect after the PR is merged)

Libraries that have their own package.json will now automatically be updated to include node_module deps that are used within the lib source code. The version of these deps are taken from the root package.json in the workspace.

Issue

[vmcbaptista]

Hi. First of all I would like to encourage this idea of adding automatically the dependencies to package.json of publishable libraries.

Although I wonder why are you updating the dependencies section of package.json while the comment of the method says:

Updates the peerDependencies section...

Also, from what I read here https://github.com/ng-packagr/ng-packagr/blob/master/docs/dependencies.md, I believe that the default behavior should be to update the peerDependencies.

Thanks for the clarifications.

[bhuber2010]

Submitted PR #3078 to change to peerDeps.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.