fix(storybook): only install the necessary package dependencies #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juristr
force-pushed
the
fix-storybook-install
branch
2 times, most recently
from
b63ff4e
to
a392ebd
Compare
FrozenPandaz
approved these changes
Apr 29, 2020
Adjust the storybook setup to just install the required dependencies, based on which ui framework has been passed to the init schematic
juristr
force-pushed
the
fix-storybook-install
branch
from
a392ebd
to
2d0cc74
Compare
4 tasks
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior (This is the behavior we have today, before the PR is merged)
Currently when configuring storybook for a React library, also Angular based dependencies get installed.
Expected Behavior (This is the new behavior we can expect after the PR is merged)
Only the minimum required package dependencies should be installed when setting up Storybook
Notes
Waiting on #2831 to go in first