fix(react): pass linter option properly to storybook cypress setup

[juristr]

Current Behavior (This is the behavior we have today, before the PR is merged)

When generating a new storybook configuration for a library with a Cypress setup, the Cypress setup uses tslint, rather than eslint. this leads to an issue because tslint requires the angular-devkit/build-angular package which isn't available in a React workspace (and shouldn't be).

Expected Behavior (This is the new behavior we can expect after the PR is merged)

• the Cypress test setup uses eslint
• a default linter option is configured for the @nrwl/react:storybook-configuration in the workspace.json

Issue

[juristr]

@jaysoo so there are a couple of things here. This PR fixes the currently broken behavior in that the React Cypress setup for Storybooks is generated with tslint, which has a dependency to angular.

While fixing this, I found that the linter defaults are set in a variety of places:

• shared-new.ts - apparently sets linter options for all schematics when react is being used. Not the cleanest way, but went for it.
• There was a problem though in the react init schematic, which had overwritten all previous @nrwl/react defaults (this PR fixes that)
• And then again the application schematic again added some of the defaults previously set in the shared-new.

So it works now, but we may want to improve how all these defaults are being initialized.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.