Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change chunkify length to 50 to prevent windows crashes #2913

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

myspivey
Copy link
Contributor

Issue 2362 requests a length of 50 as 70 was still causing issues
this pr addresses that by reducing
the length to 50

ISSUES CLOSED: #2362

Current Behavior (This is the behavior we have today, before the PR is merged)

Chunks are defined at a length of 70

Expected Behavior (This is the new behavior we can expect after the PR is merged)

Chunks are defined at a length of 50

Issue

#2362

Issue 2362 requests a length of 50 as 70 was still causing issues
this pr addresses that by reducing
the length to 50

ISSUES CLOSED: nrwl#2362
@myspivey myspivey marked this pull request as ready for review April 24, 2020 19:07
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This LGTM!

@FrozenPandaz FrozenPandaz merged commit 5cd5b7d into nrwl:master Apr 29, 2020
@myspivey myspivey deleted the fix-chunkify-length branch April 29, 2020 14:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task format:write -> Error: Command line too long
2 participants