Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): added --showConfig CLI option to Jest package #2968

Merged
merged 1 commit into from
May 8, 2020

Conversation

rossknudsen
Copy link
Contributor

Added the '--showConfig' flag to be passed down to the Jest executable to display the Jest
configuration.

ISSUES CLOSED: #2966

Current Behavior (This is the behavior we have today, before the PR is merged)

Nx ignores the config flag --showConfig when invoking the test command.

Expected Behavior (This is the new behavior we can expect after the PR is merged)

The flag should be passed down to the Jest executable to cause Jest to output it's configuration for the specified project.

Issue

#2966

Added the '--showConfig' flag to be passed down to the Jest executable to display the Jest
configuration.

ISSUES CLOSED: nrwl#2966
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

This LGTM!

@FrozenPandaz FrozenPandaz merged commit 41572b3 into nrwl:master May 8, 2020
@rossknudsen rossknudsen deleted the add-show-config-to-jest branch May 8, 2020 19:21
@rossknudsen
Copy link
Contributor Author

TBH that was a pleasure. So thanks to you guys.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add showConfig flag to Jest tests to display Jest configuration
2 participants