feat(react): make React schematics use babel-jest by default #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigAB
force-pushed
the
2365-use-babel-jest-for-react-by-default
branch
from
837d68a
to
2c754e2
Compare
The babelJest option was removed from the React application and library schematics and set to true by default ISSUES CLOSED: 2365
BigAB
force-pushed
the
2365-use-babel-jest-for-react-by-default
branch
from
2c754e2
to
3b4055e
Compare
jaysoo
approved these changes
Jun 11, 2020
Hotell
reviewed
Jun 11, 2020
There was a problem hiding this comment.
just a thought:
I'd suggest that this change would ship with migration script so consumers don't use something that isn't supported anymore.
Example:
- one may set babelJest as default within workspace schematic configuration, which with this change is obsolete and doesn't do anything.
- Also having this turned on by default without opt out may be a breaking change for some consumers that may be actively using ts-jest with react.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The babelJest option was removed from the React application
and library schematics and set to true by default
Resolves #2365 because going forward React projects (apps + libraries) would not use
ts-jestbut rather a properly configuredbabel-jestResolves #1720 for React projects at least