Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(schematics/ngrx): adding feature to empty module causes duplicate imports props #40

Closed
jeffbcross opened this issue Oct 3, 2017 · 3 comments
Labels

Comments

@jeffbcross
Copy link
Member

Running this command on an empty NgModule caused two imports properties to be added to the NgModule decorator.

Before:

@NgModule({})
export class ContactsModule {}

Generate:

$ ng g ngrx contacts --module=libs/contacts/src/contacts.module.ts

After:

@NgModule({
  providers: [ContactsEffects]
  imports: [StoreModule.forFeature('contacts', contactsReducer, {initialState: contactsInitialState})]
  imports: [EffectsModule.forFeature([ContactsEffects])]
})
@jeffbcross
Copy link
Member Author

It also didn't add a comma after providers

@vsavkin
Copy link
Member

vsavkin commented Oct 5, 2017

Duplicate of #9

@vsavkin vsavkin marked this as a duplicate of #9 Oct 5, 2017
@vsavkin vsavkin closed this as completed Oct 5, 2017
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants