Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remove generated styles.[ext] file for CSS-in-JS solutions like styled-compoentns/emotion #4347

Merged
merged 1 commit into from Dec 18, 2020

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 18, 2020

Current Behavior

New apps generated with emotion or styled-components have a bad style.[ext] global CSS file.

Expected Behavior

This file should not exist.

Related Issue(s)

Fixes #4253

@nx-cloud
Copy link

nx-cloud bot commented Dec 18, 2020

Nx Cloud Report

CI ran the following commands for commit e4b73c5. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base next 12/18/2020, 7:54:53 PM
#000000 nx build-base react 12/18/2020, 7:54:43 PM
#000000 nx run-many --target=build --all --parallel 12/18/2020, 7:54:48 PM
#000000 nx run-many --target=e2e --projects=e2e-next 12/18/2020, 7:57:21 PM
#000000 nx run-many --target=e2e --projects=e2e-react 12/18/2020, 7:57:39 PM
#000000 nx run-many --target=lint --all --parallel 12/18/2020, 7:58:16 PM
#000000 nx run-many --target=test --all --parallel 12/18/2020, 7:56:14 PM

Sent with 💌 from NxCloud.

@jaysoo jaysoo merged commit cd9b96c into nrwl:master Dec 18, 2020
@jaysoo jaysoo deleted the issues/4253 branch December 18, 2020 20:45
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx generate @nrwl/react:application produces wrong named style file
1 participant