Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): remove tslint from empty workspace and fix tslint support #4622

Merged
merged 1 commit into from Jan 27, 2021

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

tslint should appears in an empty workspace and also libs generated that use tslint won't work.

Expected Behavior

tslint should not appear in an empty workspace and also libs that use tslint should work.

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Jan 27, 2021

Nx Cloud Report

CI ran the following commands for commit 9a7fb5a. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 1/27/2021, 10:44:15 PM
#000000 nx run-many --target=e2e --projects=e2e-angular 1/27/2021, 10:46:00 PM
#000000 nx run-many --target=e2e --projects=e2e-cli,e2e-nx-plugin 1/27/2021, 10:44:52 PM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest 1/27/2021, 10:44:34 PM
#000000 nx run-many --target=e2e --projects=e2e-next,e2e-gatsby 1/27/2021, 10:44:51 PM
#000000 nx run-many --target=e2e --projects=e2e-node 1/27/2021, 10:46:25 PM
#000000 nx run-many --target=e2e --projects=e2e-react 1/27/2021, 10:45:39 PM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 1/27/2021, 10:46:42 PM
#000000 nx run-many --target=e2e --projects=e2e-workspace 1/27/2021, 10:45:04 PM
#000000 nx run-many --target=lint --all --parallel 1/27/2021, 10:47:05 PM
#000000 nx run-many --target=test --all --parallel 1/27/2021, 10:46:20 PM

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz force-pushed the fix-tslint-lib branch 4 times, most recently from 3cc0ae8 to 20efaf1 Compare January 27, 2021 20:54
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant