Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): list files from the tree in the ngcli-adapter #5860

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

In certain scenarios, when a generator runs a schematic from @schematics/angular using the wrapAngularDevkitSchematic utility, it fails with the error Unable to determine format for workspace path. This happens when those schematics read the workspace config because there is a check which only lists files from the recorded changes made during the wrapped schematic execution and from the filesystem. Any changes made by the parent generator or empty tree in tests are not going to be picked as recorded changes, since they were not done in the scope of the wrapped schematic execution.

Expected Behavior

Running a schematic from @schematics/angular should run successfully and pick files from the existing Nx DevKit Tree.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jun 1, 2021
@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6WYFmPTD3B858Fmyg5aqzg33HFsJ
✅ Preview: https://nx-dev-git-fork-leosvelperez-ng-generators-devki-a7077d.vercel.app

@nx-cloud
Copy link

nx-cloud bot commented Jun 1, 2021

Nx Cloud Report

CI ran the following commands for commit aba99b0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2

Sent with 💌 from NxCloud.

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrozenPandaz FrozenPandaz merged commit 87cae06 into nrwl:master Jun 1, 2021
@leosvelperez leosvelperez deleted the ng-generators-devkit-migration branch June 2, 2021 08:03
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants