Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make sanitizePath cross-platform #6308

Merged
merged 3 commits into from Jul 10, 2021

Conversation

dapperdandev
Copy link
Contributor

@dapperdandev dapperdandev commented Jul 8, 2021

Current Behavior

See linked issue

Expected Behavior

See linked issue

Related Issue(s)

Fixes #6280

@vercel
Copy link

vercel bot commented Jul 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/APeBSp3w1uyA2z1jjGCSSm9LNYKn
✅ Preview: Canceled

[Deployment for 0f9c2f2 canceled]

@dapperdandev
Copy link
Contributor Author

I've never used Vercel and "Details" gives me a 404. If there's anything I need to do for the build to run properly, please let me know.

@philipjfulcher philipjfulcher self-requested a review July 9, 2021 19:04
@philipjfulcher philipjfulcher self-assigned this Jul 9, 2021
@philipjfulcher
Copy link
Collaborator

Thanks for your contribution! I think this change looks good, I'm trying to work out the CI issue.

@rahulz-wasnik
Copy link

I am still facing this issue.
In fact I just pulled in the nx-example repo and ran nx dep graph on this repo and its still generating a blank page -
https://github.com/nrwl/nx-examples

@philipjfulcher
Copy link
Collaborator

@rahulz-wasnik this change was just added to one of our beta releases: 12.6.0-beta.6. Unless the repo you're using is on that version or greater, you'll continue to see the issue.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx dep-graph not generating graph
3 participants