Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslintrc format compatibility during migrations #6330

Closed
Polm1 opened this issue Jul 12, 2021 · 6 comments
Closed

Eslintrc format compatibility during migrations #6330

Polm1 opened this issue Jul 12, 2021 · 6 comments
Assignees
Labels
outdated scope: linter Issues related to Eslint support in Nx type: feature

Comments

@Polm1
Copy link

Polm1 commented Jul 12, 2021

Description

Ensure compatibility for .eslintrc.js during migrations as .eslintrc.json format currently supported.

Motivation

.js can provide access to some advantages such as exported functions benefits.

Suggested Implementation

I imagine that .eslintrc format can be choose in NX generators, then during migration will be equally treated both .json and .js formats.

@Polm1
Copy link
Author

Polm1 commented Jul 12, 2021

@meeroslav here it is the issue, many thanks again for support!

@meeroslav meeroslav self-assigned this Jul 12, 2021
@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Jul 12, 2021
@meeroslav
Copy link
Contributor

Hey @Polm1, sorry for the delay in response.

EsLint is working on the new format - eslint.config.js (you can read about it more here: https://github.com/eslint/rfcs/tree/main/designs/2019-config-simplification).

Unfortunately, due to high complexity and lack of time, instead of creating support for .eslintrc.js now and then again for new config once it lands, we would rather wait until the new format comes as it will also include compatibility mapper.

Here is the progress: eslint/eslint#13481
We will start with the adoption after stage 2.

@Polm1
Copy link
Author

Polm1 commented Aug 17, 2021

Many thanks, @meeroslav will follow updates :)

@martinplavek
Copy link

Hello @meeroslav,

is there please any chance you have started to work on adoption of the eslint.config.js files? The stage 2 should be finished except of one Change Request. I cannot see any task planned in the linter scope. Thanks for the update

@meeroslav
Copy link
Contributor

Hi, not yet but it's on the list.
The new format is already implemented in eslint, although hidden behind a flag.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: linter Issues related to Eslint support in Nx type: feature
Projects
None yet
Development

No branches or pull requests

3 participants