Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): make generated schemas compliant with json schema spec #6548

Merged
merged 1 commit into from Jul 30, 2021

Conversation

leosvelperez
Copy link
Member

Current Behavior

The generated schema.json for a workspace generator and for an Nx plugin are using the id property which is deprecated.

Expected Behavior

The generated schema.json for a workspace generator and for an Nx plugin should use the $id property.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Jul 30, 2021
@vercel
Copy link

vercel bot commented Jul 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9Q2PxisaivRinTCAHkAhwSoCQo8f
✅ Preview: Canceled

@leosvelperez leosvelperez merged commit ddfbac5 into nrwl:master Jul 30, 2021
@leosvelperez leosvelperez deleted the json-schema-compliance branch July 30, 2021 12:33
@MichaelDeBoey
Copy link
Contributor

@leosvelperez Should we have a migration to change this in the already existing schema.json too?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants