🐛 Unable to move a library using nx g @nrwl/workspace:move

[bjornharvold]

Current Behavior

I have a directory structure like this:

-libs
  \--extranet
  \--extranet-booking-engine
     \--ui-marketing-slug

I would like to move "ui-marketing-slug" to extranet.

Expected Behavior

Should copy the library to the desired destination

Steps to Reproduce

Trying to move it like this:
nx g @nrwl/workspace:move --project extranet-booking-engine-ui-marketing-slug extranet/ui-marketing-slug

Gives me the error:
path should be a path.relative()d string, but got "."

Trying to move it like this:
nx g @nrwl/workspace:move --project extranet-booking-engine-ui-marketing-slug extranet

Gives me the error:
Invalid destination: [extranet] - Path is not empty.

Environment

Node : 12.22.7
  OS   : darwin x64
  yarn : 1.22.17
  
  nx : 13.1.3
  @nrwl/angular : 13.1.3
  @nrwl/cli : 13.1.3
  @nrwl/cypress : 13.1.3
  @nrwl/devkit : 13.1.3
  @nrwl/eslint-plugin-nx : 13.1.3
  @nrwl/express : Not Found
  @nrwl/jest : 13.1.3
  @nrwl/linter : 13.1.3
  @nrwl/nest : Not Found
  @nrwl/next : Not Found
  @nrwl/node : Not Found
  @nrwl/nx-cloud : Not Found
  @nrwl/react : Not Found
  @nrwl/schematics : Not Found
  @nrwl/tao : 13.1.3
  @nrwl/web : Not Found
  @nrwl/workspace : 13.1.3
  @nrwl/storybook : 13.1.3
  @nrwl/gatsby : Not Found
  typescript : 4.3.5

[leosvelperez]

Thanks for reporting this!

Could you provide a minimal repo with a reproduction? I tried to reproduce it with the above information and I was not able to do so.

[bjornharvold]

I am trying to recreate in fresh new nx project but am unable to do so. Will close this ticket. However, I am completely unable to move a project in our current monorepo. I always get this error. If there is a way for me to debug this, I would love feedback.

Cheers

[leosvelperez]

Sorry to hear you're facing those issues.

You can first run the generator with --verbose to get the stack trace of the error and identify where in the generator code is throwing. After you've identified that, you can go to the generator code in node_modules and set up the debugger similarly to what is described here https://nx.dev/l/a/generators/workspace-generators#debugging-workspace-generators.

On a side note, this extranet/ui-marketing-slug would be the right destination to use if you want to have your library root to be libs/extranet/ui-marketing-slug.

[bjornharvold]

Thank you. Added verbose and got this:

path should be a `path.relative()`d string, but got "."
RangeError: path should be a `path.relative()`d string, but got "."
    at throwError (/Users/crash/git/monorepo/node_modules/ignore/index.js:366:9)
    at checkPath (/Users/crash/git/monorepo/node_modules/ignore/index.js:385:12)
    at Ignore._test (/Users/crash/git/monorepo/node_modules/ignore/index.js:502:5)
    at Ignore.ignores (/Users/crash/git/monorepo/node_modules/ignore/index.js:541:17)
    at Object.visitNotIgnoredFiles (/Users/crash/git/monorepo/node_modules/@nrwl/devkit/src/generators/visit-not-ignored-files.js:15:71)
    at Object.updateImports (/Users/crash/git/monorepo/node_modules/@nrwl/workspace/src/generators/move/lib/update-imports.js:40:22)
    at /Users/crash/git/monorepo/node_modules/@nrwl/workspace/src/generators/move/move.js:28:26
    at Generator.next (<anonymous>)
    at /Users/crash/git/monorepo/node_modules/tslib/tslib.js:117:75
    at new Promise (<anonymous>)

Does this give you an insight into where the issue might be?

[leosvelperez]

It looks like you have a project in your angular.json|workspace.json with "root": "." and https://www.npmjs.com/package/ignore doesn't like that path. I'll push a fix to handle that scenario.

In the meantime, you can change the projects with those paths to be just an empty string, it'll behave the same but the move generator should work with it.

Out of curiosity, what's the use case of having a project root be the workspace root?

[bjornharvold]

Hi @leosvelperez

I have no idea. This is what my angular.json workspace looks like at the bottom of the file. What should it be??

"workspace": {
      "architect": {
        "version": {
          "builder": "@jscutlery/semver:version",
          "options": {
            "syncVersions": true
          }
        }
      },
      "root": ".",
      "tags": []
    }

[leosvelperez]

You can just change "root": "." to "root": "".

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.