Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): install @angular/cli if not installed #7910

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Nov 26, 2021

Current Behavior

When adding the @nrwl/angular package to an empty workspace and generating a new Angular project, the @angular/cli package does not get installed. This can cause some issues with some tooling relying on it.

Expected Behavior

Creating a new Angular project should install @angular/cli if it is not installed.

Related Issue(s)

Fixes #7867

@leosvelperez leosvelperez self-assigned this Nov 26, 2021
@vercel
Copy link

vercel bot commented Nov 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6prPEqPfF4ExaDvhLxKrHTFZQchV
✅ Preview: Canceled

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 153e038 into nrwl:master Nov 26, 2021
@leosvelperez leosvelperez deleted the add-ng-cli-on-init branch November 26, 2021 17:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '@angular/cli' when running storybook command in new angular appliction
2 participants