New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): fix .babelrc for libraries #8075
fix(nextjs): fix .babelrc for libraries #8075
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/4guZpfexM8ynp18LekqM4YKsWVvy [Deployment for 5d1c31c canceled] |
Nx Cloud ReportCI ran the following commands for commit 5d1c31c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
eab40da
to
5d1c31c
Compare
i forget why we switched away from @jaysoo do you happen to recall why we switched away from |
just a side note but this also fixes the issue that custom libraries are not able to be unit tested. with the published solution you'll get this error:
|
3a99403
to
334c230
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The
.babelrc
generated bynx g @nrwl/next:library
does not use@nrwl/next/babel
preset.Expected Behavior
It should be generated with
@nrwl/next/babel
preset.Related Issue(s)
https://nrwlcommunity.slack.com/archives/C015WMB2A8P/p1639043467125800
https://nrwlcommunity.slack.com/archives/C015WMB2A8P/p1641384957180500
#6728