Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): upgrade to React 18 #9847

Merged
merged 1 commit into from Apr 19, 2022
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 14, 2022

BREAKING CHANGE: react-router API has changed, and @testing-library/react-hooks has been deprecated (See: https://nx.dev/guides/react-18)

  • Add a migration to React 18 (React Native 0.68 update will be in a separate PR).
  • We'll automatically change the render(...) call, and provide a guide for React Router v6 migration.
  • @testing-library/react-hook is deprecated and does not support React 18. We've provided a workaround until RTL provides renderHook.

New migration guide: https://nx-dev-git-fork-jaysoo-nx14-react-router-update-nrwl.vercel.app/guides/react-18

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@nx-cloud
Copy link

nx-cloud bot commented Apr 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 415aaac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4gRzzyguN4GjU5UusCKnqX8ZKrxj
✅ Preview: https://nx-dev-git-fork-jaysoo-nx14-react-router-update-nrwl.vercel.app

@jaysoo jaysoo force-pushed the nx14/react-router-update branch 2 times, most recently from 4e61c34 to 4515963 Compare April 15, 2022 03:30
@jaysoo jaysoo changed the title feat(react): upgrade to react-router v6 feat(react): upgrade to react 18 Apr 15, 2022
@jaysoo jaysoo changed the title feat(react): upgrade to react 18 feat(react): upgrade to React 18 Apr 15, 2022
@ndcunningham ndcunningham marked this pull request as ready for review April 16, 2022 03:21
@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 2:37PM (UTC)

BREAKING CHANGE: react-router API has changed, and @testing-library/react-hooks has been deprecated (See: https://nx.dev/guides/react-18)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant