Missing tests - Adding two missing tests and re-ordering existing tests. #134
Conversation
I am getting some ideas for impementation of an algorithm which can be a good addition to the lib. This lib is great as far as the code is concerned, I intend to contribute and open up more PRs further. 馃槃 |
Oops, got a little |
Only Python3.2 check fails. I don't know why. |
The reason this test is failing is because |
Well, that was smooth.. now fit to be merged ! 馃憤 If I find a good algorithm to implement, I will send a new PR soon, it was pleasure using your library and working with it ! 馃槃 |
@nryoung this will get stale, please suggest workarounds 馃槃 |
@karandesai-96 This is still on my radar to review. Don't worry about it getting stale. I will get to it soon. |
Cool. Whenever you get to it. If there is any test remaining, please let me know -- I will push a commit in no time. 馃槂 |
Thank you for your contribution! These changes look solid, just have one comment: Can you squash and rebase your commits to a single commit with a short but descriptive commit message about your changes. Take a look at: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request if you need help. |
Sure, I will do it right away. |
- Add test for BogoSort and PrimalityTest. - Reorder tests in other files alphabetically. - Align all files according to PEP8 guidelines.
@nryoung I was away for a while. I did as you said, all commits squashed in two commits, but one:
|
@nryoung A gentle reminder 馃槃 |
This looks good! Thank you for the hard work. |
Thank you 馃槃 |
.idea/
directory which does not need to be on Github, so I also updated the gitignore file in the PR.