Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

is prime, prime decomposition and totient functions #71

Closed
wants to merge 6 commits into from

Conversation

johnmarinelli
Copy link

I made a PR a LOOOONG time ago and completely forgot to add tests, so it was closed - here is that same request with tests! Apologies for taking months...

@JoaoGFarias
Copy link
Contributor

Great work @johnmarinelli, and sorry for taking months to reply.
Could you break the headers comments to a limit of 80 chars per line.
This way, is easier to read on GitHub or text editors.

@johnmarinelli
Copy link
Author

No problem & will do.

@nryoung
Copy link
Owner

nryoung commented Sep 18, 2015

Thanks for your contribution.

A couple of things:

  1. It is preferred to make a PR from a topic branch off of your master, please see: https://help.github.com/articles/using-pull-requests/
  2. We also prefer to have a clean commit history, so if you could squash your commits and rebase off of master that would be ideal. Please see: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request as a guide.

Feel free to reopen with fixes.

@nryoung nryoung closed this Sep 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants