Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining /hirs/data/persist/ unit tests in HIRS_Utils (Pt. 1) #593

Closed
4 of 5 tasks
iadgovuser59 opened this issue Sep 20, 2023 · 1 comment · Fixed by #603
Closed
4 of 5 tasks

Migrate remaining /hirs/data/persist/ unit tests in HIRS_Utils (Pt. 1) #593

iadgovuser59 opened this issue Sep 20, 2023 · 1 comment · Fixed by #603
Assignees
@iadgovuser62
Labels
good first issue Good for newcomers migration Update to RHEL 8
Milestone
Rocky 8 Migration

Comments

@iadgovuser59
Copy link
Collaborator

iadgovuser59 commented Sep 20, 2023 •
edited by iadgovuser62
Loading

This issue tracks migrating HIRS_Utils unit tests in the folder HIRS_Utils/src/test/java/hirs/data/persist/ from the master branch to the main branch as part of the ongoing effort. The following files should be migrated as part of this issue:

  • PortalInfoTest
  • SupplyChainValidationSummaryTest (will be saved for later; see below)
  • SupplyChainValidationTest
  • PlatformCredentialTest
  • CertificateTest
@iadgovuser59 iadgovuser59 added good first issue Good for newcomers migration Update to RHEL 8 labels Sep 20, 2023
@iadgovuser59 iadgovuser59 added this to the Rocky 8 Migration milestone Sep 20, 2023
@iadgovuser62
Copy link

iadgovuser62 commented Oct 3, 2023 •
edited
Loading

Completed migration for: PortalInfoTest and SupplyChainValidationTest, plus PlatformCredentialTest and CertificateTest which were dependencies from HIRS_Utils/src/test/java/hirs/data/persist/certificate. They have yet to be merged into main. SupplyChainValidationSummaryTest is pending, as it has more complex dependencies.

  • PlatformCredentialTest
  • CertificateTest

@iadgovuser62 iadgovuser62 mentioned this issue Oct 4, 2023
Merged
@iadgovuser62 iadgovuser62 linked a pull request Oct 4, 2023 that will close this issue
[#593] HIRS_Utils Unit Tests #603
Merged
iadgovuser59 pushed a commit that referenced this issue Oct 5, 2023
@iadgovuser62
[#593] HIRS_Utils Unit Tests (#603)
10c2884 
* Added test path to HIRS_AttestationCA, including PortalInfoTest. Also added testImplementation lines to the subproject's build.gradle to give those classes access to JUnit5.

* Adding PlatformCredentialTest and CertificateTest, along with necessary resources in test path of HIR_AttestationCA

* Adding SupplyChainValidationTest
chubtub pushed a commit that referenced this issue Oct 17, 2023
@iadgovuser62 @chubtub
[#593] HIRS_Utils Unit Tests (#603)
d4c12f2 
* Added test path to HIRS_AttestationCA, including PortalInfoTest. Also added testImplementation lines to the subproject's build.gradle to give those classes access to JUnit5.

* Adding PlatformCredentialTest and CertificateTest, along with necessary resources in test path of HIR_AttestationCA

* Adding SupplyChainValidationTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iadgovuser62 iadgovuser62

Labels
good first issue Good for newcomers migration Update to RHEL 8
Projects
None yet
Milestone
Rocky 8 Migration
Development

Successfully merging a pull request may close this issue.

[#593] HIRS_Utils Unit Tests nsacyber/HIRS
2 participants
@iadgovuser59 @iadgovuser62