Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PciIds from AttestationCA back to Utils #757

Open
iadgovuser58 opened this issue Apr 26, 2024 · 0 comments
Open

Move PciIds from AttestationCA back to Utils #757

iadgovuser58 opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@iadgovuser58
Copy link
Collaborator

iadgovuser58 commented Apr 26, 2024

The class PciIds is in AttestationCA. However, PciIds is needed to process SPDM event log structures defined in the PFP (specifically DEVICE_SECURITY_EVENT_DATA_PCI_CONTEXT), and the event log classes are in Utils. PciIds class cannot be accessed from Utils without creating a circular dependency. Need to 1) move PciIds back into Utils, 2) Update DeviceSecurityEventDataPciContext to use PciIds to report Vendor and Device IDs.

PciIds depends on 3 classes in AttestationCA, which in turn depend on more classes. To move PciIds, ALL of these classes will have to move to Utils. Here are the following dependencies:

PciIds depends on:

  • ComponentIdentifier
  • ComponentIdentifierV2, which depends on:
    • ComponentAddress
    • ComponentClass
    • ComponentIdentifier [see above]
    • URIReference
  • ComponentResult, which depends on:
    • ArchivableEntity, which depends on:
      • AbstractEntity
    • ComponentAddress [see above]
    • ComponentIdentifier [see above]
    • AttributeStatus
    • ComponentIdentifierV2 [see above]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant