Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Observasjoner #459

Closed
2 tasks done
EllaKrossen opened this issue Sep 26, 2022 · 3 comments
Closed
2 tasks done

Text Observasjoner #459

EllaKrossen opened this issue Sep 26, 2022 · 3 comments
Assignees
@leiferikbjorkli
Labels
enhancement New feature or request 🎀 Komponenter react-native Has to do with the React Native implementation

Comments

@EllaKrossen
Copy link
Contributor

EllaKrossen commented Sep 26, 2022 •
edited by selbekk
Loading

Is your feature request related to a problem? Please describe.

  • Mange av de gamle tekst-komponentene i salgsappen er ofte wrappet i en ComponentToUseWhenTextScalingTooLarge, det er ikke laget noe tilsvarende eller lagt inn noe støtte for dette i Text i Spor.
  • Text variant er ikke required, burde kanskje være det?
@EllaKrossen EllaKrossen added enhancement New feature or request 🔨 React Has to do with the React implementation react-native Has to do with the React Native implementation 🎀 Komponenter labels Sep 26, 2022
@selbekk
Copy link
Contributor

selbekk commented Sep 29, 2022

Mange av de gamle tekst-komponentene i salgsappen er ofte wrappet i en ComponentToUseWhenTextScalingTooLarge, det er ikke laget noe tilsvarende eller lagt inn noe støtte for dette i Text i Spor.

Det er ikke lagt til støtte for i dag, men det kan vi godt gjøre.

Text variant er ikke required, burde kanskje være det?

Enig, det burde vi få til.

@selbekk selbekk removed the 🔨 React Has to do with the React implementation label Sep 29, 2022
@selbekk
Copy link
Contributor

selbekk commented Jan 21, 2023

Dette med "ComponentToUseWhenTextScalingTooLarge" kan jo være noe vi kan se på i forbindelse med "maks-størrelse" på tekst, @leiferikbjorkli . Setter denne på deg enn så lenge jeg :)

@selbekk
Copy link
Contributor

selbekk commented Feb 17, 2023

Fiksa scaling også nå :)

@selbekk selbekk closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiferikbjorkli leiferikbjorkli

Labels
enhancement New feature or request 🎀 Komponenter react-native Has to do with the React Native implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@selbekk @leiferikbjorkli @EllaKrossen