Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value class #42

Merged
merged 3 commits into from
Jun 20, 2013
Merged

value class #42

merged 3 commits into from
Jun 20, 2013

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Jun 20, 2013

remane implicit methods due to name conflicts.

@kmizu
Copy link

kmizu commented Jun 20, 2013

@xuwei-k Currently, nscala-time is cross-built against Scala 2.9.X and Scala 2.10.X.
Using value classes means dropping Scala 2.9.X support. Should we do that now ?

@xuwei-k
Copy link
Member Author

xuwei-k commented Jun 20, 2013

Using value classes means dropping Scala 2.9.X support

no. extends AnyRef if scala 2.9.x
see

nscala-time/build.sbt

Lines 37 to 42 in 5882028

unmanagedSourceDirectories in Compile <+= (scalaVersion, sourceDirectory in Compile){(v, dir) =>
if(v.startsWith("2.9"))
dir / "scala29"
else
dir / "scala210"
}

https://github.com/nscala-time/nscala-time/blob/58820280a201e9ae96c10bcb768964c51d6ff772/src/main/scala29/com/github/nscala_time/time/package.scala

@gakuzzzz
Copy link
Member

It's cool!

@kmizu
Copy link

kmizu commented Jun 20, 2013

Oh, I see. I misunderstood. All right.

@ghost ghost assigned kmizu Jun 20, 2013
kmizu pushed a commit that referenced this pull request Jun 20, 2013
@kmizu kmizu merged commit f0c810b into master Jun 20, 2013
@xuwei-k xuwei-k mentioned this pull request Aug 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants