Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some typing hint to support older numpy ? #16

Closed
ProV1denCEX opened this issue Dec 10, 2021 · 5 comments
Closed

Remove some typing hint to support older numpy ? #16

ProV1denCEX opened this issue Dec 10, 2021 · 5 comments

Comments

@ProV1denCEX
Copy link

Hello, I got an error ModuleNotFoundError: No module named 'numpy.typing' due to the typing hint from numpy.typing import ArrayLike.

Would you mind remove this hint to support older numpy version like 1.19.* ? It seems no performance issue after remove it.
@nschloe
Copy link
Owner

nschloe commented Dec 10, 2021

What python version are you using?

@ProV1denCEX
Copy link
Author

python 3.7.8 with numpy 1.19.5

@nschloe
Copy link
Owner

nschloe commented Dec 13, 2021

So why don't you upgrade to numpy 1.20? They support Python 3.7+.

@ProV1denCEX
Copy link
Author

cz many other packages like pytorch require a numpy version <=1.19.*
and I don't think removing typing hint is a breaking change for matplotx.

@nschloe
Copy link
Owner

nschloe commented Dec 14, 2021

cz many other packages like pytorch require a numpy version <=1.19.*

I just installed torch with numpy 1.21, no problem.

@nschloe nschloe closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nschloe @ProV1denCEX