New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node HID check for browser error #245

Closed

CaptainThrillsDev opened this issue Feb 11, 2023 · 0 comments · Fixed by #246

Assignees

Contributor

CaptainThrillsDev commented Feb 11, 2023

Describe the bug
node_hid_provider is checking for window type undefined, typeof window === 'undefined' though

To Reproduce
Please provide exact package version and steps to reproduce the behavior:

Try and run with node-hid

Expected behavior
Update check to correctly use 'undefined'

CaptainThrillsDev assigned nsfm

CaptainThrillsDev mentioned this issue

Fix undefined window check for hid provider #246

Merged

nsfm closed this as completed in #246

nsfm mentioned this issue

Enable @typescript-eslint/strict #253

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment