Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic local pref values should be concrete after solve #16

Closed
alehed opened this issue May 15, 2018 · 6 comments
Closed

Symbolic local pref values should be concrete after solve #16

alehed opened this issue May 15, 2018 · 6 comments

Comments

@alehed
Copy link
Collaborator

alehed commented May 15, 2018

The local pref values are the only things that are symbolic in the config, therefor they should be used to set the path preference and not be symbolic after running NetComplete.

  • Test-case: test_symbolic_local_pref in tests/test_bgpver.py.
@ahassany
Copy link
Member

This is similar to Issue #12

@alehed
Copy link
Collaborator Author

alehed commented May 15, 2018

Also here the solver claims unsat. I might look into it tomorrow.

@alehed
Copy link
Collaborator Author

alehed commented May 16, 2018

The problem is more specifically seen in #19. Closing until the problem lies with the local pref.

@alehed alehed closed this as completed May 16, 2018
@alehed
Copy link
Collaborator Author

alehed commented May 17, 2018

Ok, a specific problem popped up again. Setting the SetLocalPref action to symbolic causes the test to fail for no good reason.

@alehed alehed reopened this May 17, 2018
@ahassany
Copy link
Member

Is this still an issue, I don't see the test case anymore in the code

@alehed
Copy link
Collaborator Author

alehed commented May 26, 2018

I think this particular thing is not an issue any more.

@alehed alehed closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants