Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning provided when the requirements are not implementable with the current sketch #9

Open
alehed opened this issue May 3, 2018 · 1 comment

Comments

@alehed
Copy link
Collaborator

alehed commented May 3, 2018

Currently when providing netcomplete with an example that requires routemaps in the sketch in order to implement the constraint and the sketch does not have any routemaps, it doesn't fail to produce the configs.

  • Expected behavior: The solver does not say sat or the synthesis fails in some other way before that.
  • Actual behavior: The solver says sat.
  • Test case: test_simplified_bgp_configuration in grigori's 'tests/test_bgpgen.py'
@ahassany
Copy link
Member

Ideally the three checks (compute_dags, synthesis, and calling the SMT solver)should be merged into one API call. This would be short future API update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants