Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging module usage in place of print calls #511

Closed
chuckwondo opened this issue Apr 8, 2024 · 2 comments · Fixed by #566
Closed

Add logging module usage in place of print calls #511

chuckwondo opened this issue Apr 8, 2024 · 2 comments · Fixed by #566
Assignees
@botanical
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chuckwondo
Copy link
Collaborator

There are a number of calls to print throughout the code base that should probably be replaced with appropriate calls to the standard logging library.
@mfisher87 mfisher87 added bug Something isn't working good first issue Good for newcomers labels Apr 8, 2024
@botanical botanical mentioned this issue May 11, 2024
Merged
@botanical
Copy link
Contributor

Hello 👋 I opened a PR here #566. I'm unable to assign this to myself but I did check the open PRs and it doesn't look like anyone has addressed this issue yet.

@mfisher87 mfisher87 linked a pull request May 21, 2024 that will close this issue
Replace print statements with logger #566
Merged
@mfisher87
Copy link
Member

Resolved by #566 , thank you @botanical !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@botanical botanical

Labels
bug Something isn't working good first issue Good for newcomers
Projects
earthaccess project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace print statements with logger botanical/earthaccess
3 participants
@mfisher87 @chuckwondo @botanical