This repository has been archived by the owner on Feb 20, 2022. It is now read-only.
Bigfixes, framework updates, support for font resources. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBIMC
commented
Oct 18, 2017
MrBIMC
commented
- fixed potentially broken vector drawables on pre-lollipop devices
- added support for font resources introduced with supportlib-v26
- broke ResourcesAware interface as it now requires Pair<Context, Resources> instead of just Resources
nsk-mironov
reviewed
Oct 18, 2017
| @@ -15,20 +15,28 @@ allprojects { | |||
| buildscript { | |||
| repositories { | |||
| jcenter() | |||
| maven { | |||
There was a problem hiding this comment.
You can just use google() instead.
| } | ||
| } | ||
|
|
||
| repositories { | ||
| jcenter() | ||
| maven { |
| factory() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| val resources: Resources | ||
| val resources: Pair<Context, Resources> |
There was a problem hiding this comment.
Any particular reason for this change? You don't actually need a Context.
| typed("color", kotlin.Int::class.java) -> resources.getColor(id) | ||
| typed("color", java.lang.Integer::class.java) -> resources.getColor(id) | ||
| typed("color", ColorStateList::class.java) -> resources.getColorStateList(id) | ||
| typed("color", kotlin.Int::class.java) -> ContextCompat.getColor(context, id) |
There was a problem hiding this comment.
Any reason to use ContextCompat instead of ResourcesCompat?
| typed("color", java.lang.Integer::class.java) -> resources.getColor(id) | ||
| typed("color", ColorStateList::class.java) -> resources.getColorStateList(id) | ||
| typed("color", kotlin.Int::class.java) -> ContextCompat.getColor(context, id) | ||
| typed("color", java.lang.Integer::class.java) -> ContextCompat.getColor(context, id) |
| typed("color", ColorStateList::class.java) -> resources.getColorStateList(id) | ||
| typed("color", kotlin.Int::class.java) -> ContextCompat.getColor(context, id) | ||
| typed("color", java.lang.Integer::class.java) -> ContextCompat.getColor(context, id) | ||
| typed("color", ColorStateList::class.java) -> ContextCompat.getColorStateList(context, id) |
|
|
||
| else -> throw UnsupportedOperationException("Unsupported resource (name = \"${resources.getResourceName(id)}\", type = \"${clazz.canonicalName}\")") | ||
| typed("font", Typeface::class.java) -> ResourcesCompat.getFont(context, id) |
There was a problem hiding this comment.
Ooops, now I see why you need a Context
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.