Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda packaging for Python 3.10 #81

Closed
mrakitin opened this issue Jan 19, 2022 · 2 comments
Closed

conda packaging for Python 3.10 #81

mrakitin opened this issue Jan 19, 2022 · 2 comments
Labels
future-proofing needed for dependency changes and version compatibility

Comments

@mrakitin
Copy link
Member

conda-forge/csxtools-feedstock#3 failed with a missing import. Need to resolve it on the package level and release a new version with the fix.

import: 'csxtools'
/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/pims/image_reader.py:26: RuntimeWarning: PIMS image_reader.py could not find scikit-image. Falling back to matplotlib's imread(), which uses floats instead of integers. This may break your scripts. 
(To ignore this warning, include the line "warnings.simplefilter("ignore", RuntimeWarning)" in your script.)
  warnings.warn(RuntimeWarning(ski_preferred))
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/test_tmp/run_test.py", line 2, in <module>
    import csxtools
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/csxtools/__init__.py", line 3, in <module>
    from .utils import (get_fastccd_images, get_fastccd_timestamps)  # noqa F401
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/csxtools/utils.py", line 3, in <module>
    from pims import pipeline
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/pims/__init__.py", line 1, in <module>
    from pims.api import *
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/pims/api.py", line 19, in <module>
    from .cine import Cine  # noqa
  File "/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/pims/cine.py", line 29, in <module>
    from collections import Iterable
ImportError: cannot import name 'Iterable' from 'collections' (/home/conda/feedstock_root/build_artifacts/csxtools_1642620788862/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/collections/__init__.py)
Tests failed for csxtools-0.1.16-py310hb5077e9_1.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
@ambarb ambarb added the future-proofing needed for dependency changes and version compatibility label Jan 19, 2022
@ambarb
Copy link
Contributor

ambarb commented Jan 19, 2022

slack channel note:
from collections.abc import Iterable

@mrakitin
Copy link
Member Author

This was resolved, and version 0.1.16 was built with Python 3.10 via conda-forge/csxtools-feedstock#5.

Currently building v0.1.18 from PyPI via conda-forge/csxtools-feedstock#7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future-proofing needed for dependency changes and version compatibility
Projects
None yet
Development

No branches or pull requests

2 participants