don't return the command name in list of arguments #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
force-pushed
the
fix/remove-command-from-argument-list
branch
4 times, most recently
from
9bb0d42
to
f4d1a41
Compare
|
Hi, what is the status of this PR? I don't mind if you don't want to incorporate it for concern of breaking existing users. What do you think? |
|
Hello @armcknight, Sorry for not replying earlier I kind of miss setup the notifications. I will check this over the weekend :). |
| @@ -25,7 +25,8 @@ class ArgsTests: QuickSpec { | |||
| "no-ff": ""] | |||
|
|
|||
| expect(Args.parsed.flags).to(equal(result)) | |||
| expect(Args.parsed.parameters).to(equal(["Some custom one", "one", "two"])) | |||
| expect(Args.parsed.parameters).to(equal(["one", "two"])) | |||
| expect(Args.parsed.command).to(equal("Some custom one")) | |||
There was a problem hiding this comment.
This expectation here is a little misleading, I think we should refactor this test.
we can set the process info above to be
ProcessInfo.internalProcessInfo = DummyProcessInfo("excutable_name", "-f", "file.rb", "--integer", "1", "Some custom one", "one", "two", "--no-ff")
and then edit this expectation to be
expect(Args.parsed.command).to(equal("excutable_name"))
|
This looks super cool! I have added one note on the unit test. |
armcknight
force-pushed
the
fix/remove-command-from-argument-list
branch
from
f4d1a41
to
153e6b6
Compare
- fix unit test mock and expectations in ArgsTests
armcknight
force-pushed
the
fix/remove-command-from-argument-list
branch
from
153e6b6
to
7955f11
Compare
|
Hey @oarrabi , thanks for the comments, I updated all the things requested! |
|
This is awesome! |
nsomar
added a commit
that referenced
this pull request
Feb 15, 2016
…ent-list don't return the command name in list of arguments
|
👍 Thanks for the library, enjoying using it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior line up with description in the README