Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent NEOFS_NETWORK_DOMAIN parameter #14

Open
roman-khimov opened this issue Nov 14, 2023 · 0 comments
Open

Inconsistent NEOFS_NETWORK_DOMAIN parameter #14

roman-khimov opened this issue Nov 14, 2023 · 0 comments
Labels
bug Something isn't working config Configuration format update or breaking change I2 Regular impact S3 Minimally significant U3 Regular
Milestone

Comments

@roman-khimov
Copy link
Member

Current Behavior

NEOFS_NETWORK_DOMAIN is about some domain, previously we've used it as a generic top-level domain and workflow automatically added stX to it. Now it's a node address effectively which is OK (allows to use private nodes, for example), but it's somewhat misleading in its name and also missing any ability to specify port. It's also unobvious if it supports scheme specification (grpcs://, anyone?).

Expected Behavior

Have some NEOFS_NODE or NEOFS_ENDPOINT parameter that accepts a simple string that is used for RPC endpoint.

Possible Solution

Will require 0.2.0 since it's a breaking change (but we can think of some deprecation/compat in 0.1.3).

@roman-khimov roman-khimov added the bug Something isn't working label Nov 14, 2023
@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I2 Regular impact config Configuration format update or breaking change labels Dec 20, 2023
@roman-khimov roman-khimov added this to the v0.4.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config Configuration format update or breaking change I2 Regular impact S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

1 participant